-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Don't parse and reserialize toml in configure.py #112445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which toml file you mean in "without needing to parse the toml itself"? Is |
The toml in the |
I think your idea is suitable for "appending a new toml config to |
Oh, when |
PR hasn't been updated in a while so removing assignment |
Removing python scripts task supersedes this. It's better to close it before people waste their time on it. |
Currently, configure.py has a lot of code dedicated to parsing and serializing toml: https://github.com/rust-lang/rust/blob/6959dd0ee3e8c0c11d3ea54b258dfaf24f148a49/src/bootstrap/configure.py#L382-L509
90% of this is unnecessary: when we get
--set rust.foo
as an argument, we can writerust.foo = true
directly to config.toml, without needing to parse the toml itself. That should make configure.py a lot simpler, and as a side effect it means the hack to append a profile will be valid toml again: #112281 (comment)@rustbot label E-easy E-mentor
The text was updated successfully, but these errors were encountered: