-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Description
There are some things in rustc that are named historically or just really oddly. This issue tracks renaming them to reflect what they are without having to understand Rust's history and/or programming language design/theory jargon.
- Region -> Lifetime in general. While Region kinda makes more sense, we use Lifetime in the language
-
EarlyBoundRegion
->GenericLifetime
(to reflect what they are in the language) -
LateBoundRegion
->HigherRankedLifetime
(") -
*Folder
andfold_*
->*Replacer
andreplace_*
- update internal terminology:
Substs
->GenericArgs
#110793 -
subst
->replace_generics
These changes have an accepted MCP at rust-lang/compiler-team#451
Note: please do not pick up any of these work items without first checking in with me. These renamings aren't universally liked and we should make sure everyone stays on board.
I'm not gonna move on these things quickly, and I'm fine closing PRs even after putting in lotsa work. So if anyone has concerns, please raise them on a zulip thread or directly with me.
joboet, m-ou-se, ehuss, workingjubilee, saethlin and 18 more
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.