Propose "unsafe fields" as a 2025H1 Project Goal #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Nov 6, 2024
nikomatsakis
approved these changes
Nov 8, 2024
Comment on lines
+71
to
+72
| 3. **Safe Usage is Usually Safe** | ||
| Uses of `unsafe` fields which cannot violate their invariants *should not* require an unsafe block. |
There was a problem hiding this comment.
What does this mean, in practice?
There was a problem hiding this comment.
For example: Using offset_of has no impact on the safety invariants of its given field. Requiring unsafe { ... } to compute the offset of an unsafe field would be pure noise in an unsafe code review, and, as such, we should make an effort to not require unsafe { ... } in this case.
Unlike the first and second tenet, this tenet is a soft requirement. We shouldn't ignore it entirely in our design work, but we don't actually have to implement any of these safe carve-outs initially since it's forwards-compatible to make an unsafe operation safe (so long as doing so doesn't violate existing safety conditions).
nikomatsakis
added a commit
to nikomatsakis/rust-project-goals-ndm
that referenced
this pull request
Jun 5, 2025
Propose "unsafe fields" as a 2025H1 Project Goal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links: