Skip to content

Use same column resize handle as rustdoc and mdbook #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use same column resize handle as rustdoc and mdbook #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ui/frontend/Playground.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,27 @@

.splitRowsGutterHandle {
transform: rotate(90deg);
}

.splitColumnsGutterHandle, .splitRowsGutterHandle {
pointer-events: none;
display: flex;
align-items: center;
gap: 2px;
}

.splitColumnsGutterHandle::before, .splitRowsGutterHandle::before {
content: "";
width: 2px;
height: 12px;
border-left: dotted 2px currentColor;
}

.splitColumnsGutterHandle::after, .splitRowsGutterHandle::after {
content: "";
width: 2px;
height: 16px;
border-right: dotted 2px currentColor;
}

.splitColumnsGutter {
Expand Down
4 changes: 2 additions & 2 deletions ui/frontend/Playground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const UNFOCUSED_GRID_STYLE = {

const HANDLE_STYLES = {
[Orientation.Horizontal]: [styles.splitRowsGutter, styles.splitRowsGutterHandle],
[Orientation.Vertical]: [styles.splitColumnsGutter, ''],
[Orientation.Vertical]: [styles.splitColumnsGutter, styles.splitColumnsGutterHandle],
}

// We drop down to lower-level split-grid code and use some hooks
Expand Down Expand Up @@ -72,7 +72,7 @@ const ResizableArea: React.FC = () => {
<div className={styles.editor}><Editor /></div>
{ isFocused &&
<div ref={dragHandle} className={handleOuterStyle}>
<span className={handleInnerStyle}>⣿</span>
<span className={handleInnerStyle}></span>
</div>
}
{ somethingToShow && <div className={styles.output}><Output /></div>}
Expand Down