Skip to content

Conversation

Alexendoo
Copy link
Member

Follow up to #9709 / #9541

There's a good number of PRs with some leftover src/docs files for example, and as a reviewer it's something we're used to ignoring so it can easily slip through

r? @flip1995

changelog: none

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 25, 2022
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

r=me with the comment added.


/// Remove files no longer needed after <https://github.com/rust-lang/rust-clippy/pull/9541>
/// that may be reintroduced unintentionally
fn remove_old_files(update_mode: UpdateMode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a fixme comment, that this should only exist temporarily, and should be removed once no PRs that add those files exist anymore

@Alexendoo Alexendoo force-pushed the old-generated-files branch from e44b879 to 22d435b Compare October 25, 2022 13:20
@Alexendoo
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Oct 25, 2022

📌 Commit 22d435b has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 25, 2022

⌛ Testing commit 22d435b with merge 634987b...

@bors
Copy link
Contributor

bors commented Oct 25, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 634987b to master...

@bors bors merged commit 634987b into rust-lang:master Oct 25, 2022
@Alexendoo Alexendoo deleted the old-generated-files branch October 25, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants