[nonstandard_macro_braces] Do not modify macro arguments
#9499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kraktus
force-pushed
the
nonstandard_macro_braces
branch
3 times, most recently
from
52f7f9f to
a4144d7
Compare
Contributor
|
☔ The latest upstream changes (presumably #9471) made this pull request unmergeable. Please resolve the merge conflicts. |
xFrednet
approved these changes
Sep 21, 2022
Contributor
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
LGTM, we can merge this after a rebase 🙃 (I was hoping that the other PR would not cause a conflict, sorry 🙃 )
Contributor
Author
|
Thought it would avoid it too! Will rebase tonight |
Contributor
Author
|
No time in the end, will see later, this weekend max |
Contributor
|
That's all right, don't stress yourself. 🙃 |
kraktus
force-pushed
the
nonstandard_macro_braces
branch
from
a4144d7 to
a390115
Compare
Also simplify the lint by not caring about code format which should be `rustfmt` job, and turn the lint into machine Applicable
Contributor
|
Looks good to me, thank you for the rebase 🙃 @bors r+ |
Contributor
Contributor
Contributor
Author
|
strangely locally git could rebase without any issue 🤔 |
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9498
based on top of #9471
Also simplify the lint by not caring about code format which should be
rustfmtjob, and turn the lint into machine Applicablechangelog: Suggestion: [
nonstandard_macro_braces]: The suggestion is now machine applicable and will no longer replace brackets inside the macro argument.#9499