Fix the emission order of trait_duplication_in_bounds
#9397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Emit the lint in source order * Make suggestions with multiple traits be in source order rather than alphabetical
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
added
the
I-sync-blocker
dswij
reviewed
Aug 31, 2022
Jarcho
commented
Aug 31, 2022
| | | ||
| LL | fn bad_foo<T: Clone + Default, Z: Copy>(arg0: T, arg1: Z) | ||
| | ^^^^^^^ | ||
| | ^^^^^ |
There was a problem hiding this comment.
Both this and the next warning were both emitted with the order depending on the order of a hash map. I guess there was a change recently that caused the order be reversed.
dswij
approved these changes
Aug 31, 2022
|
Thanks for the fix! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the lint emit in source order rather than whatever order the hash map happens to be in. This is currently blocking the sync into rustc.
changelog: None