Skip to content

unused_self: respect avoid-breaking-exported-api #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented Jul 18, 2022

changelog: [`unused_self`]: Now respects the `avoid-breaking-exported-api` config option

Fixes #9195.

I mostly copied the implementation from unnecessary_wraps, since I don't have much understanding of rustc internals.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 18, 2022
@Jarcho
Copy link
Contributor

Jarcho commented Jul 18, 2022

Thank you.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 18, 2022

📌 Commit 7a5965b has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 18, 2022

⌛ Testing commit 7a5965b with merge bf70865...

@bors
Copy link
Contributor

bors commented Jul 18, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing bf70865 to master...

@bors bors merged commit bf70865 into rust-lang:master Jul 18, 2022
@bors bors mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused_self: respect avoid-breaking-exported-api
4 participants