identity_op: add parenthesis to suggestions where required
#8786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @dswij I hope it's okay to steal this one from you @Manishearth 🙃 |
|
yeah please go for it! |
xFrednet
approved these changes
May 24, 2022
Comment on lines
+80
to
+84
| // ensure we're checking against the leftmost expression of `right` | ||
| // | ||
| // ~~~ `lhs` | ||
| // 0 + {4} * 2 | ||
| // ~~~~~~~ `right` |
There was a problem hiding this comment.
I love this kind of documentation ^^
|
📌 Commit ee8fae3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
identity_op]: add parenthesis to suggestions where requiredFollow up to #8730, wraps the cases we can't lint as-is in parenthesis rather than ignoring them
Catches a couple new FPs with mixed operator precedences and
ascastsThe suggestions are now applied using
span_lint_and_suggrather than appearing in just the message and have arun-rustfixtest