Skip to content

Run fmt test before compile-test/dogfood #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

Alexendoo
Copy link
Member

I seem to always forget to run cargo dev fmt before doing a test. This lets it fail fast rather than going through the much longer compile-test/dogfood tests first

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 2, 2022
@flip1995
Copy link
Member

flip1995 commented Apr 5, 2022

I mean, why not. Renaming the test file seems like a hack, but after a quick google search it seems this is the only way how to do this.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 5, 2022

📌 Commit 515b4ec has been approved by flip1995

@bors
Copy link
Contributor

bors commented Apr 5, 2022

⌛ Testing commit 515b4ec with merge 511752f...

@bors
Copy link
Contributor

bors commented Apr 5, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 511752f to master...

@bors bors merged commit 511752f into rust-lang:master Apr 5, 2022
@Alexendoo Alexendoo deleted the test-fmt-first branch April 5, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants