Rework undocumented_unsafe_blocks
#8450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
unsafe_blocks_8449
branch
4 times, most recently
from
96ae551 to
f2d4327
Compare
Jarcho
force-pushed
the
unsafe_blocks_8449
branch
from
f2d4327 to
ac04157
Compare
Jarcho
force-pushed
the
unsafe_blocks_8449
branch
from
ac04157 to
65f96e2
Compare
Jarcho
changed the title
undocumented_unsafe_blocksundocumented_unsafe_blocks
Contributor
Author
|
This should be good to go now. |
giraffate
reviewed
Mar 30, 2022
Contributor
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Can the comment about style that are no longer supported be added to What it does section on this lint?
|
|
||
| #[rustfmt::skip] | ||
| fn inline_block_comment() { | ||
| /* Safety: */unsafe {} |
Contributor
There was a problem hiding this comment.
It would be better to leave this as it is and add comments not to support this style.
giraffate
approved these changes
Apr 4, 2022
Contributor
|
@bors r+ It looks good, thanks! |
Contributor
|
📌 Commit 17c8bee has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8264
fixes: #8449
One thing came up while working on this. Currently comments on the same line are supported like so:
Is this worth supporting at all? Anything other than a couple of words doesn't really fit well.
edit: zulip topic
changelog: Don't lint
undocumented_unsafe_blockswhen the unsafe block comes from a proc-macro.changelog: Don't lint
undocumented_unsafe_blockswhen the preceding line has a safety comment and the unsafe block is a sub-expression.