Skip to content

Conversation

@Serial-ATA
Copy link
Contributor

@Serial-ATA Serial-ATA commented Oct 29, 2021

changelog: none

  • Print float and int suffixes
  • Print labels
  • Struct field checks
  • Repeat length expression check
  • Destructure method calls
  • Destructure closures

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 29, 2021
@Serial-ATA Serial-ATA force-pushed the extend-author-lint branch 2 times, most recently from 7a7fad1 to 7e9f966 Compare October 30, 2021 19:47
@Serial-ATA Serial-ATA force-pushed the extend-author-lint branch 2 times, most recently from 73509df to b9437e1 Compare October 31, 2021 04:36
@bors
Copy link
Contributor

bors commented Nov 2, 2021

☔ The latest upstream changes (presumably #7906) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@camsteffen camsteffen added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 5, 2021
@camsteffen
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2021

📌 Commit c96cd35 has been approved by camsteffen

bors added a commit that referenced this pull request Nov 6, 2021
Extend author lint

changelog:
* Print float and int suffixes
* Print labels
* Struct field checks
* Repeat length expression check
* Destructure method calls
* Destructure closures
@bors
Copy link
Contributor

bors commented Nov 6, 2021

⌛ Testing commit c96cd35 with merge 219e0bd...

@bors
Copy link
Contributor

bors commented Nov 6, 2021

💔 Test failed - checks-action_test

@camsteffen
Copy link
Contributor

@bors retry (fixed changelog)

@bors
Copy link
Contributor

bors commented Nov 6, 2021

⌛ Testing commit c96cd35 with merge e3d1e60...

@bors
Copy link
Contributor

bors commented Nov 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing e3d1e60 to master...

@bors bors merged commit e3d1e60 into rust-lang:master Nov 6, 2021
@Serial-ATA Serial-ATA deleted the extend-author-lint branch November 6, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants