Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 30, 2021

fixes: #7245
changelog: Add lint suspicious_splitn

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 30, 2021
@Jarcho Jarcho force-pushed the suspicious_splitn branch from 6011fe4 to 898b6a0 Compare May 30, 2021 13:50
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented May 30, 2021

📌 Commit 5fa08ea has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Testing commit 5fa08ea with merge d1308ae...

@bors
Copy link
Contributor

bors commented May 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d1308ae to master...

@bors bors merged commit d1308ae into rust-lang:master May 30, 2021
@bors bors mentioned this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on SplitN with a count of 1
4 participants