Skip to content

Conversation

@giraffate
Copy link
Contributor

Fix #6343

changelog: Fix FP in unnecessary_lazy_evaluations

@rust-highfive
Copy link

r? @llogiq

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 23, 2020
@llogiq
Copy link
Contributor

llogiq commented Dec 7, 2020

Sorry it took me so long. @bors r+

@bors
Copy link
Contributor

bors commented Dec 7, 2020

📌 Commit cdbf639 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Dec 7, 2020

⌛ Testing commit cdbf639 with merge 9d6bdb3...

bors added a commit that referenced this pull request Dec 7, 2020
…s, r=llogiq

Fix FP in `unnecessary_lazy_evaluations`

Fix #6343

changelog: Fix FP in `unnecessary_lazy_evaluations`
@bors
Copy link
Contributor

bors commented Dec 7, 2020

💔 Test failed - checks-action_dev_test

@llogiq
Copy link
Contributor

llogiq commented Dec 7, 2020

Seems to need cargo dev fmt, perhaps rustfmt has changed?

@giraffate giraffate force-pushed the fix_fp_in_unnecessary_lazy_evaluations branch from cdbf639 to ba12494 Compare December 7, 2020 07:46
@giraffate
Copy link
Contributor Author

Yes, rustfmt seems to be updated. I added cargo dev fmt commit in this PR.

@flip1995
Copy link
Member

flip1995 commented Dec 7, 2020

Thanks, it seems that rustfmt learnt about the matches! macro:)

@bors r=llogiq,flip1995

@bors
Copy link
Contributor

bors commented Dec 7, 2020

📌 Commit ba12494 has been approved by llogiq,flip1995

@bors
Copy link
Contributor

bors commented Dec 7, 2020

⌛ Testing commit ba12494 with merge aaed9d9...

@bors
Copy link
Contributor

bors commented Dec 7, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq,flip1995
Pushing aaed9d9 to master...

@bors bors merged commit aaed9d9 into rust-lang:master Dec 7, 2020
@giraffate giraffate deleted the fix_fp_in_unnecessary_lazy_evaluations branch December 14, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for unnecessary_lazy_evaluations

5 participants