Skip to content

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Oct 13, 2020

Ignore expr that originate from a macro.

Fixes: #6168

changelog: none

@rust-highfive
Copy link

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 13, 2020
@ThibsG ThibsG force-pushed the SameFunctionsInIfConditionIgnoreMacro branch from 9260564 to 58d4665 Compare October 13, 2020 09:30
@ThibsG ThibsG force-pushed the SameFunctionsInIfConditionIgnoreMacro branch from 58d4665 to e212408 Compare October 13, 2020 09:31
@ebroto
Copy link
Contributor

ebroto commented Oct 13, 2020

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 13, 2020

📌 Commit e212408 has been approved by ebroto

@bors
Copy link
Contributor

bors commented Oct 13, 2020

⌛ Testing commit e212408 with merge 0b77c35...

@bors
Copy link
Contributor

bors commented Oct 13, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 0b77c35 to master...

@bors bors merged commit 0b77c35 into rust-lang:master Oct 13, 2020
@ThibsG ThibsG deleted the SameFunctionsInIfConditionIgnoreMacro branch October 13, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP same_functions_in_if_condition with cfg!() with macro as condition
4 participants