Replace some lazy_static usage with once_cell feature #6120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Neat! |
|
📌 Commit 832d39f has been approved by |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Replace some lazy_static usage with once_cell feature This replaces some `lazy_static` usage with [`SyncLazy`](https://doc.rust-lang.org/nightly/std/lazy/struct.SyncLazy.html) of the unstable `once_cell` feature. changelog: none
|
💔 Test failed - checks-action_test |
|
Will get to the failure later today, looks like a doctest was importing lazy_static |
phansch
force-pushed
the
replace-lazy-static
branch
from
832d39f to
da57a16
Compare
|
@bors r=Manishearth |
|
📌 Commit da57a16 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Oct 12, 2020
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Oct 12, 2020
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Oct 12, 2020
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Oct 12, 2020
bors
added a commit
that referenced
this pull request
Oct 12, 2020
Remove lazy_static completely and use once_cell feature instead Follow-up to #6120 This removes the last remaining `lazy_static` usages and replaces them with `SyncLazy` from the `once_cell` feature. --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces some
lazy_staticusage withSyncLazyof the unstableonce_cellfeature.changelog: none