Rustfmt clippy #540
Rustfmt clippy #540
Conversation
Manishearth
force-pushed
the
fmt
branch
2 times, most recently
from
5bc5577 to
d9b1232
Compare
There was a problem hiding this comment.
This kind of change looks strange to me. It leaves tons of space on the left, and moves the important part quite a lot to the right.
Is there a rustfmt option to keep the original here?
There was a problem hiding this comment.
I can't see one, but I could be wrong. Mostly okay with this formatting though.
|
Done reviewing. @llogiq @birkenfeld do you also want to go through this? Otherwise ready to merge. The few cases of the const stuff -- we can look into that as a followup (since it's a few cases only), either with a rustfmt_skip or by tweaking rustfmt itself. |
|
I'll have a look later this evening (in 3-4 hours). |
|
I'm also not too fond of the "Visual" default formatting for many items; the code becomes quite right-biased this way. But I'm OK with merging; we can experiment with different settings later. |
|
Yeah, I feel the same. |
Remove rustfmt::skip attribute from register_plugins function r? `@Manishearth` since you added this in #540 😄 changelog: none
4 participants
Will review code changes myself.