Add suggestions for if_let_some_result
#5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Jan 10, 2020
|
Also, renamed files and module to |
|
☔ The latest upstream changes (presumably #5040) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnTitor
force-pushed
the
add-sugg-some-result
branch
from
f4a06b9 to
5ded8ef
Compare
|
☔ The latest upstream changes (presumably #5042) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnTitor
force-pushed
the
add-sugg-some-result
branch
from
5ded8ef to
56feda1
Compare
JohnTitor
added
the
S-waiting-on-review
JohnTitor
force-pushed
the
add-sugg-some-result
branch
from
56feda1 to
7e76a19
Compare
flip1995
reviewed
Jan 19, 2020
flip1995
reviewed
Jan 19, 2020
|
Thanks, now this should be a rock solid suggestion! @bors r+ |
|
📌 Commit c9f8d03 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 19, 2020
Add suggestions for `if_let_some_result` Fixes #4991 This approach may be fragile though... changelog: Add suggestions for `if_let_some_result`
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4991
This approach may be fragile though...
changelog: Add suggestions for
if_let_some_result