Skip to content

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Nov 29, 2019

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move use_self lint to nursery, due to many false positives

Closes rust-lang#4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties S-waiting-on-bors Status: The marked PR was approved and is only waiting bors labels Nov 29, 2019
@flip1995
Copy link
Member

update_lints should have updated clippy_lints/src/lib.rs too.

@phansch
Copy link
Contributor Author

phansch commented Nov 29, 2019

Huh, indeed. Not at my Clippy machine right now but I will check later today. Maybe I just forgot to commit that file.

@flip1995 flip1995 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 29, 2019
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2019

📌 Commit fd7eca2 has been approved by flip1995

bors added a commit that referenced this pull request Nov 29, 2019
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@bors
Copy link
Contributor

bors commented Nov 29, 2019

⌛ Testing commit fd7eca2 with merge 5de93cc...

@bors
Copy link
Contributor

bors commented Nov 29, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Contributor Author

phansch commented Nov 29, 2019

It looks like something's wrong with the changelog: detection:

KeyError: 'body'
ERROR: PR body must (cut off)

If there's no body key in the response, it's probably an error response.

@phansch
Copy link
Contributor Author

phansch commented Nov 29, 2019

@bors retry - maybe it was a temporary issue

@bors
Copy link
Contributor

bors commented Nov 29, 2019

⌛ Testing commit fd7eca2 with merge 0403687...

bors added a commit that referenced this pull request Nov 29, 2019
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@bors
Copy link
Contributor

bors commented Nov 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 0403687 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: The marked PR was approved and is only waiting bors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The use_self lint has too many bugs open - should be disabled by default

3 participants