Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next I will try to break this lint into 2 as suggested in #4648 (comment) |
flip1995
reviewed
Oct 26, 2019
flip1995
added
the
S-waiting-on-author
yerke
commented
Nov 10, 2019
flip1995
reviewed
Nov 12, 2019
flip1995
reviewed
Nov 12, 2019
flip1995
requested changes
Nov 12, 2019
yerke
force-pushed
the
fix-check_infinite_loop
branch
2 times, most recently
from
45dc16f to
2342e6e
Compare
yerke
commented
Nov 13, 2019
yerke
changed the title
flip1995
reviewed
Nov 13, 2019
flip1995
reviewed
Nov 15, 2019
flip1995
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Does it look like you wanted to see?
Yes that's exactly what I wanted to see.
Do I understand correctly that we probably don't need to split into another lint any more now?
This PR is already a big improvement. But I'd rather still split the lint up in a correctness and a style lint.
BTW, I opened #4835 as I am hitting the same issue as Travis CI
I'll include this in #4825. Thanks for the report.
yerke
force-pushed
the
fix-check_infinite_loop
branch
from
4265143 to
1cba0c9
Compare
|
@bors r+ rollup |
|
📌 Commit 1cba0c9 has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 23, 2019
…p1995 Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body changelog: Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body fixes rust-lang#4648
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 6 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4764 (Allow casts from the result of `checked_abs` to unsigned) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost changelog: none
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 23, 2019
…p1995 Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body changelog: Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body fixes rust-lang#4648
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 5 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body changelog: Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body fixes #4648
|
@bors retry queue prio |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 5 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body
fixes #4648