Small refactoring of methods/mod.rs #4443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tackling @bors r+ |
|
📌 Commit 2da8288 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 24, 2019
Small refactoring of methods/mod.rs
|
💔 Test failed - checks-travis |
|
I took the liberty to add the @bors retry |
bors
added a commit
that referenced
this pull request
Aug 24, 2019
Small refactoring of methods/mod.rs changelog: none
ghost
reviewed
Aug 24, 2019
| return; | ||
| } | ||
| let mut finder = FunCallFinder { cx: &cx, found: false }; | ||
| if { finder.visit_expr(&arg); finder.found }; |
There was a problem hiding this comment.
This should have been flagged by block_in_if_condition_stmt
There was a problem hiding this comment.
This may have been skipped because of a macro check in the lint?
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none