Skip to content

Conversation

@flip1995
Copy link
Member

Some of these PRs would be great if they could be completed. But I guess no-one would look through closed PRs if they want to contribute. Let's point (new) contributors there by mentioning these PRs in the CONTRIBUTING.md

@phansch
Copy link
Contributor

phansch commented Dec 27, 2018

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit b5e545a has been approved by phansch

@bors
Copy link
Contributor

bors commented Dec 27, 2018

⌛ Testing commit b5e545a with merge dfe1232...

bors added a commit that referenced this pull request Dec 27, 2018
Mention S-inactive-closed PRs in the CONTRIBUTING.md

Some of these PRs would be great if they could be completed. But I guess no-one would look through closed PRs if they want to contribute. Let's point (new) contributors there by mentioning these PRs in the `CONTRIBUTING.md`
@bors
Copy link
Contributor

bors commented Dec 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing dfe1232 to master...

@bors bors merged commit b5e545a into rust-lang:master Dec 27, 2018
@flip1995 flip1995 deleted the contrib_inactive_prs branch December 27, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants