Downgrade large_digit_groups to pedantic #3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe if the user already decided to put underscores in their literal, Clippy should be willing to believe that they put a number of underscores that they felt was readable.
phansch
added
the
S-waiting-on-review
|
does this affect |
|
This lint does not affect 0b01110000011100110_u64. The only lint currently triggered on: fn main() {
let _ = 0b01110000011100110_u64;
}is unreadable_literal. Large_digit_groups would be 0b01110_000011_100110_u64 for example. |
|
Thanks for checking up on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe if the user already decided to put underscores in their literal, Clippy should be willing to believe that they put a number of underscores that they felt would be readable.
changelog: Remove large_digit_groups from default set of enabled lints