Add lint for calling mem::discriminant on a non-enum type
#3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HMPerson1
force-pushed
the
mem_discrim
branch
from
25bcf2b to
06e3bee
Compare
Contributor
Author
|
not sure what happened here https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/444259747 |
Member
Timeout, happens sometimes. I restarted it |
flip1995
reviewed
Oct 21, 2018
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Applicability level of this lint is missing.
Could you add a test for calling this function inside of a macro? Most of the time macros result in weird suggestions/behavior.
HMPerson1
force-pushed
the
mem_discrim
branch
from
bc16b2c to
40239ce
Compare
flip1995
reviewed
Oct 24, 2018
HMPerson1
force-pushed
the
mem_discrim
branch
from
ed2d1f0 to
d53e6f8
Compare
Member
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2018
3346: Add lint for calling `mem::discriminant` on a non-enum type r=flip1995 a=HMPerson1 Also, if the type is a reference to an enum, we suggest removing `&`s and/or dereferencing. Fixes #3342 Co-authored-by: HMPerson1 <[email protected]> Co-authored-by: Philipp Krones <[email protected]>
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, if the type is a reference to an enum, we suggest removing
&s and/or dereferencing.Fixes #3342