Add copy_iterator lint (#1534) #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
requested changes
Aug 24, 2018
clippy_lints/src/copy_iterator.rs
Outdated
| let ty = cx.tcx.type_of(cx.tcx.hir.local_def_id(item.id)); | ||
|
|
||
| if is_copy(cx, ty) && match_path(&trait_ref.path, &paths::ITERATOR) { | ||
| span_lint_and_then( |
There was a problem hiding this comment.
You can use the utils::span_note_and_lint function here.
|
Thanks. Rebased + using |
flip1995
approved these changes
Aug 24, 2018
|
Oh nvm. Already passed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the easier part of #1534, i.e. detecting when
CopyandIteratorare implemented on the same type.