Add explicit_default_arguments lint #16123
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is close to finished, all that is left is having it check a few more places (e.g. inside turbofish syntax in expressions), walk through types recursively, improve the lint message, and improve the tests. A refactor might be good as well.
I'm opening this draft PR because I would like to get some feedback before finishing the lint completely. I would appreciate it if someone could take a look to see if everything is in order. The implementation is basically looking at the fully resolved type and checks the alias type and type alias to determine if an argument is unnecessary.
.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtfixes #14848