Skip to content

Conversation

@samueltardieu
Copy link
Member

Basis for enabling handling of f16 and f128 in other existing lints.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@dswij dswij added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@dswij
Copy link
Member

dswij commented Oct 17, 2025

@samueltardieu seems like some CI job failed

@samueltardieu
Copy link
Member Author

@samueltardieu seems like some CI job failed

Yeah, it looks like MSVC doesn't support some things related to either f16 or f128, I'll investigate.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 17, 2025
@samueltardieu samueltardieu force-pushed the features/constant-f16-f128 branch from d2c4a42 to e03c7af Compare October 27, 2025 06:58
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@samueltardieu samueltardieu force-pushed the features/constant-f16-f128 branch from e03c7af to 48c7a1d Compare November 5, 2025 12:19
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants