feat: #[clippy::ignore_interior_mutability] attribute
#15844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
Author
rustbot
added
S-blocked
ada4a
force-pushed
the
13865-ignore_interior_mutability
branch
from
f1810d7 to
ab48eee
Compare
Contributor
|
This is going to need a discussion. Unlike the config, the person adding the attribute is not same person who suffers the outcome. Two things of the top of my head:
For the name I would use |
This comment has been minimized.
This comment has been minimized.
Their meanings, and the way they're handled in `get_attr`, are pretty similar
- Move it and its helper function `parse_attrs` together to the end of the file, because it's surprising to see front-and-center a struct that's only really used in one place (`cognitive_complexity`). - Avoid panic path in `LimitStack::limit` - Replace `assert` with `debug_assert` to avoid panics in release builds
This will be required for the next commit -- kept as a separate commit to reduce noise
ada4a
force-pushed
the
13865-ignore_interior_mutability
branch
from
ab48eee to
1087095
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
If we do go with the attribute, it should also be documented in |
Collaborator
|
☔ The latest upstream changes (possibly 7562179) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13865
Unresolved questions:
changelog: introduce
#[clippy::ignore_interior_mutability]attribute, analogous to the config option of the same namer? @llogiq