Skip to content

unwrap.rs cleanup #14761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

unwrap.rs cleanup #14761

merged 2 commits into from
May 9, 2025

Conversation

samueltardieu
Copy link
Member

This cleans up unwrap.rs:

  • use interned symbols instead of strings
  • update names to reflect the current implementation
  • replaced a cascaded if by a shorter match

changelog: none

@samueltardieu
unwrap.rs: replace some strings usage by interned symbols
668a292
@samueltardieu
unwrap.rs: internal naming cleanup
4cbd116 
Since its conception, the lint has been extended from `Option`
only to `Option` and `Result`, but some function names and comment still
references only `Option`.

Also, one cascaded `if` was replaced by a shorter `match`.
@rustbot
Copy link
Collaborator

rustbot commented May 8, 2025

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 8, 2025
@Manishearth
Copy link
Member

r? clippy

about to go on vacation for a week

@rustbot rustbot assigned dswij and unassigned Manishearth May 8, 2025
@samueltardieu samueltardieu mentioned this pull request May 8, 2025
Merged
dswij
dswij approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@dswij dswij added this pull request to the merge queue May 9, 2025
Merged via the queue into rust-lang:master with commit a67ee90 May 9, 2025
11 checks passed
@samueltardieu samueltardieu deleted the push-mnqksxkoukpy branch May 9, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samueltardieu @rustbot @Manishearth @dswij