Misc changes #14702
Merged
Misc changes #14702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
lifetime_ice
branch
3 times, most recently
from
2ba91dd to
3ff1ad4
Compare
This comment has been minimized.
This comment has been minimized.
y21
approved these changes
May 3, 2025
Member
y21
left a comment
y21
left a comment
There was a problem hiding this comment.
Looks good, r=me after the rebase. Looks like it's just an #[allow] that got added
Contributor
Author
|
Ping @y21 in case github didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes
with_leading_whitespacenot always adding the whitespace it can.changelog: None