Skip to content

iter_kv_map: recognize references on maps as well #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

iter_kv_map: recognize references on maps as well #14596

merged 1 commit into from
Apr 21, 2025

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Apr 11, 2025 •
edited by rustbot
Loading

Fix #14595

changelog: [iter_kv_map]: recognize references on maps as well

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 11, 2025
blyxyas
blyxyas approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Apr 21, 2025
Merged via the queue into rust-lang:master with commit 48430c2 Apr 21, 2025
11 of 13 checks passed
@samueltardieu samueltardieu deleted the issue14595 branch May 6, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clippy fails to report .values() over .iter().map(|(_, v)| v) through .as_ref()
3 participants
@samueltardieu @rustbot @blyxyas