Skip to content

fix: equatable_if_let suggests wrongly when involving reference #14504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix: equatable_if_let suggests wrongly when involving reference #14504

merged 1 commit into from
Apr 26, 2025

Conversation

profetia
Copy link
Contributor

Closes #8710

changelog: [equatable_if_let] fix wrong suggestions when involving reference

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 30, 2025
@profetia profetia force-pushed the issue8710 branch 2 times, most recently from 5001b93 to 960863f Compare March 30, 2025 07:41
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Centri3 and unassigned dswij Apr 15, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned dswij and unassigned Centri3 Apr 24, 2025
@dswij dswij added this pull request to the merge queue Apr 26, 2025
Merged via the queue into rust-lang:master with commit 58cfdb7 Apr 26, 2025
11 checks passed
@profetia profetia deleted the issue8710 branch September 12, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

equatable_if_let suggests wrong code when it involves a reference
4 participants
@profetia @rustbot @dswij @Centri3