Skip to content

Improve needless_pass_by_value suggestion #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Improve needless_pass_by_value suggestion #13880

merged 2 commits into from
Mar 10, 2025

Conversation

GuillaumeGomez
Copy link
Member

Fixes #13744.

A simple check to check if the type is an Option allows to improve the suggestion.

changelog: Improve needless_pass_by_value suggestion

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 26, 2024
@GuillaumeGomez
Copy link
Member Author

r? clippy

@rustbot rustbot assigned Manishearth and unassigned dswij Dec 26, 2024
oriongonza
oriongonza reviewed Dec 26, 2024
View reviewed changes
@Manishearth
Copy link
Member

r? clippy

bit swamped

@rustbot rustbot assigned dswij and unassigned Manishearth Jan 5, 2025
@dswij dswij added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Feb 8, 2025
@GuillaumeGomez GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Feb 11, 2025
@dswij dswij mentioned this pull request Mar 8, 2025
Closed
@dswij
Copy link
Member

dswij commented Mar 8, 2025

@GuillaumeGomez can you try force re-pushing to retrigger the CI? Seems like it's stuck.

@GuillaumeGomez GuillaumeGomez force-pushed the improve-needless_pass_by_value branch from 2874288 to 79013f8 Compare March 8, 2025 20:08
@GuillaumeGomez
Copy link
Member Author

Done.

@GuillaumeGomez
Copy link
Member Author

Rebasing was a good idea apparently since it allowed to see some failures that weren't there originally. CI is all green now. :)

@flip1995 flip1995 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into rust-lang:master with commit a25cbd5 Mar 10, 2025
11 checks passed
@GuillaumeGomez GuillaumeGomez deleted the improve-needless_pass_by_value branch March 10, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

+1 more reviewer

@oriongonza oriongonza oriongonza left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poor suggestion on needless_pass_by_value on Option
6 participants
@GuillaumeGomez @rustbot @Manishearth @dswij @oriongonza @flip1995