Skip to content

Move internal lints to their own crate #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Move internal lints to their own crate #13223

merged 1 commit into from
Apr 18, 2025

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Aug 6, 2024

This makes it so switching the internal feature on/off no longer rebuilds clippy_lints.

r? @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 6, 2024
@Jarcho Jarcho force-pushed the internal_lint branch 2 times, most recently from 6274ff4 to 6320f1a Compare August 6, 2024 05:00
flip1995
flip1995 reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like those changes. Splitting up Clippy definitely makes sense. We might also want to look into turning Clippy into a workspace, like cargo did. I think @xFrednet wanted to look into this.

@bors
Copy link
Contributor

bors commented Aug 6, 2024

☔ The latest upstream changes (presumably #13225) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Aug 6, 2024
@Jarcho
Copy link
Contributor Author

Jarcho commented Aug 6, 2024

Marking this as blocked on #13221

@Jarcho Jarcho removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Aug 20, 2024
@Jarcho
Copy link
Contributor Author

Jarcho commented Aug 20, 2024

r? rust-lang/clippy

This was simplified a bit by #13221.

@rustbot rustbot assigned y21 and unassigned flip1995 Aug 20, 2024
Alexendoo
Alexendoo reviewed Aug 21, 2024
View reviewed changes
tests/dogfood.rs
Copy link
Member

@Alexendoo Alexendoo Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with adding the new crate to the list of dogfooded crates

@Jarcho Jarcho force-pushed the internal_lint branch 3 times, most recently from 8314085 to 34be10e Compare August 23, 2024 13:57
y21
y21 reviewed Aug 24, 2024
View reviewed changes
clippy_internal_lints/src/lib.rs
];

pub fn register_lints(store: &mut LintStore) {
store.register_lints(LINTS);
Copy link
Member

@y21 y21 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer registers the clippy::internal group. I assume that's intentional since it's not needed anymore for #![deny(clippy::internal)] in tests and -Dclippy::internal as all internal lints are now warn by default?

Copy link
Contributor Author

@Jarcho Jarcho Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal category is now completely gone. It was only really needed to mark some generated code with #[cfg(feature = "internal")].

@bors
Copy link
Contributor

bors commented Sep 4, 2024

☔ The latest upstream changes (presumably #13343) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
@Jarcho Jarcho force-pushed the internal_lint branch 3 times, most recently from 72a5f4f to 03fa013 Compare April 12, 2025 10:41
@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 12, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 12, 2025
samueltardieu
samueltardieu reviewed Apr 12, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The book references the utils/internal directory in development/defining_lints.md as being the directory where internal lints are stored. This should probably be updated.

smoelius
smoelius reviewed Apr 12, 2025
View reviewed changes
tests/ui-internal/collapsible_span_lint_calls.fixed
@@ -1,4 +1,4 @@
#![deny(clippy::internal)]
#![deny(clippy::collapsible_span_lint_calls)]
Copy link
Contributor

@smoelius smoelius Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I'm curious, were changes like this necessitated by the move? Or is this just to clarify the deny's purpose?

Copy link
Contributor Author

@Jarcho Jarcho Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal category no longer exists.

@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 12, 2025

Just removed the reference from the book. internal since it doesn't fit anymore nor are they common enough to really warrant making them easier.

@Jarcho Jarcho mentioned this pull request Apr 15, 2025
Merged
@samueltardieu samueltardieu mentioned this pull request Apr 17, 2025
Merged
y21
y21 approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y21 y21 added this pull request to the merge queue Apr 18, 2025
Merged via the queue into rust-lang:master with commit 781fdab Apr 18, 2025
11 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2025
@dswij
clippy_dev refactor (#14616)
40bead0 
Based on #13223

Various refactoring on `clippy_dev` before upgrading rename and
splitting `clippy_lints` into multiple crates.

Some improvements:
* The working directory is set to the root clippy directory. Running
from a subdirectory was kind of supported before sometimes. Now it just
works.
* File won't be written unless they're actually updated. Most of the
time they weren't written, but a few cases slipped through.
* Buffers are reused more for the negligible speed boost.

changelog: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Alexendoo Alexendoo Alexendoo left review comments

@flip1995 flip1995 flip1995 left review comments

@y21 y21 y21 approved these changes

+1 more reviewer

@smoelius smoelius smoelius left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Jarcho @bors @rustbot @samueltardieu @Alexendoo @flip1995 @y21 @smoelius