Deprecate maybe_misused_cfg and mismatched_target_os
#12875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
y21
commented
Jun 1, 2024
| //~^ ERROR: no need to put clippy lints behind a `clippy` cfg | ||
| #![cfg_attr(clippy, deny(clippy::non_minimal_cfg, clippy::maybe_misused_cfg))] |
There was a problem hiding this comment.
I'm not sure exactly why/how that lint was used here, so I just removed it to avoid any "this lint has been deprecated" warnings
|
Thanks for doing this! I kept forgetting it... @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All cases that these two lints would catch are now caught by cargo/rustc's own check-cfg feature.
This was previously discussed on zulip: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Deprecate.20maybe_misused_cfg.20and.20mismatched_target_os
For the most part, this PR was automated with
cargo dev deprecater? @flip1995 cc @Urgau
changelog: deprecate [
maybe_misused_cfg] and [mismatched_target_os]