Skip to content

Conversation

J-ZhengLi
Copy link
Member

closes: #12568


changelog: allow [manual_unwrap_or_default] in const function

This is a small fix, I was originally decided to fix it along with #12568 but there are some problems needs to be addressed (which is why my branch is called issue12569 😆 ), so I decide to open a separated PR to fix them one at a time.

@rustbot
Copy link
Collaborator

rustbot commented Mar 27, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 27, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Mar 28, 2024

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Mar 28, 2024

📌 Commit c27f52d has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 28, 2024

⌛ Testing commit c27f52d with merge 124e68b...

@bors
Copy link
Contributor

bors commented Mar 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 124e68b to master...

@bors bors merged commit 124e68b into rust-lang:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_unwrap_or_default should not trigger in constant context (false positive)
4 participants