Add a lint to warn about un-necessary .into_iter() #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarton
reviewed
Oct 1, 2016
| @@ -577,6 +596,16 @@ fn check_for_loop_arg(cx: &LateContext, pat: &Pat, arg: &Expr, expr: &Expr) { | |||
| object, | |||
| method_name)); | |||
| } | |||
| } else if method_name.as_str() == "into_iter" && match_trait_method(cx, arg, &paths::I) { | |||
There was a problem hiding this comment.
This should be INTO_ITERATOR
There was a problem hiding this comment.
Yeah miss commit.
mcarton
reviewed
Oct 1, 2016
| @@ -87,7 +87,7 @@ impl Unrelated { | |||
| } | |||
| } | |||
|
|
|||
| #[deny(needless_range_loop, explicit_iter_loop, iter_next_loop, reverse_range_loop, explicit_counter_loop)] | |||
| #[deny(needless_range_loop, explicit_iter_loop, explicit_into_iter_loop, iter_next_loop, reverse_range_loop, explicit_counter_loop)] | |||
There was a problem hiding this comment.
We usually just do #[deny(clippy)]. I wonder why this file does not use that.
There was a problem hiding this comment.
Don't know for sure. Let me clean that up in a separate pr.
| @@ -294,6 +294,10 @@ fn main() { | |||
| for _v in vec.iter() { } //~ERROR it is more idiomatic to loop over `&vec` | |||
| for _v in vec.iter_mut() { } //~ERROR it is more idiomatic to loop over `&mut vec` | |||
|
|
|||
|
|
|||
| let mut _out_vec = vec![1,2,3]; | |||
There was a problem hiding this comment.
Not needed. Let me remove it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1094.