Fix iter_kv_map false positive into_keys and into_values suggestion #11757
Conversation
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
This should probably also update the lint documentation:
rust-clippy/clippy_config/src/conf.rs
Line 252 in 902c79c
|
Thanks for pointing that out, I updated the documentation |
|
☔ The latest upstream changes (presumably #11750) made this pull request unmergeable. Please resolve the merge conflicts. |
matthri
force-pushed
the
iter-kv-map-msrv-fix
branch
from
840481f to
d77b9be
Compare
| ) { | ||
| if map_type == "into_iter" && !msrv.meets(msrvs::INTO_KEYS) { | ||
| return; | ||
| } | ||
| if !expr.span.from_expansion() | ||
| && let ExprKind::Closure(c) = m_arg.kind |
There was a problem hiding this comment.
This lint should probably check that the closure doesn't have parameter- or return type annotations since that can help type inference or make the map closure act as a coercion site.
Not your problem though, that could be a PR on its own, unless you also want to try to fix that here ^^.
Examples where the machine applicable suggestion breaks: coercions, inference
There was a problem hiding this comment.
I will have a try fixing this, but I think I will open a separate PR so this one doesn't get too cluttered ^^
|
Thanks! @bors r+ |
Fix iter_kv_map false positive into_keys and into_values suggestion fixes: #11752 changelog: [`iter_kv_map`]: fix false positive: Don't suggest `into_keys()` and `into_values()` if the MSRV is to low
|
💔 Test failed - checks-action_test |
matthri
force-pushed
the
iter-kv-map-msrv-fix
branch
from
d77b9be to
a20f61b
Compare
|
I ran the |
|
Yeah a note would be good, would be good for us to see if we can make it automatic also |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Add documentation update hint using `cargo collect-metadata` This adds a little reminder to update the documentation in the book using `cargo collect-metadata` after changing the lint configuration since this can easily be missed (been there done that 🙈). > Yeah a note would be good, would be good for us to see if we can make it automatic also _Originally posted by `@Alexendoo` in #11757 (comment) Regarding the automation Im not sure whats the best option here. I thought about a kind of a "semi-automated" way, e.g. a `cargo dev` command which runs the "is the documentation updated" check (and maybe other useful checks) locally and reminds the user of updating the documentation so this gets caught before pushing. changelog: none
fixes: #11752
changelog: [
iter_kv_map]: fix false positive: Don't suggestinto_keys()andinto_values()if the MSRV is to low