Split explicit_iter_loop lint into deref and std versions
#11406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing this raised issue: rust-lang#11074 The lint adds too much visual noise when deref lints are enforced. This commit splits the explicit_iter_loop into two versions, the first, `std`, where non-deref types are linted, and the second `deref` where deref types are linted.
Fix the explicit_iter_loop tests after splitting the lint into deref and std versions. This completes the work of splitting the lint and leaving only the standard (non-deref) aspect in general warn.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
Fix the dogfood test. I also previously misunderstood `pedantic` designations. This adds both `explicit_iter_loop_deref` and `explicit_iter_loop_std` as pedantic lints. The split allows users to decide to ignore only the deref lint.
Fix failing doctests from changes, and add `explicit_iter_loop` -> `explicit_iter_loop_std` to renamed lints list.
Fix failing rename test after renaming explicit_iter_loop.
|
A poll for how we want to handle this: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60explicit_iter_loop.60 |
|
Closing after discussion on Zulip recommended disabling the lint for reborrows only via a configuration flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split [
explicit_iter_loop] into [explicit_iter_loop_std] and [explicit_iter_loop_deref].The purpose of this PR is to fix issue #11074 where the suggested code from explicit_iter_loop was too symbol dense for the
derefversions of the lint. The proposed solution is to split the lint into two. Theexplicit_iter_loop_derefcan then be allowed by those that use pedantic linting, prefer the standard iter loop, but dislike the added symbol clutter of the deref version.For quick reference, deref versions:
*x&*x&mut *xStd versions:
x&x&mut xAll tests passing locally.
fixes #11074
changelog: [
explicit_iter_loop]: Split [explicit_iter_loop] into [explicit_iter_loop_std] and [explicit_iter_loop_deref].