[derivable_impls
]: don't lint if default()
call expr unsize-coerces to trait object
#10954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10158.
This fixes a FP where the derive-generated Default impl would have different behavior because of unsize coercion from
Box<T>
toBox<dyn Trait>
:(this intentionally only looks for trait objects
dyn
specifically, and not any unsize coercion, e.g.&[i32; 5]
to&[i32]
, because that breaks existing tests and isn't actually problematic, as far as I can tell)changelog: [
derivable_impls
]: don't lint ifdefault()
call expression unsize-coerces to trait object