Skip to content

[missing_panics_doc]: pickup expect method #10953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 16, 2023
Merged

[missing_panics_doc]: pickup expect method #10953

merged 5 commits into from
Jun 16, 2023

Conversation

@KisaragiEffective
Copy link
Contributor

@KisaragiEffective KisaragiEffective commented Jun 14, 2023

close #10240

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [missing_panics_doc]: pickup expect method

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2023
dswij
dswij reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The lint itself looks great. Just a small comment

We have a test for missing_panics_doc here https://github.com/rust-lang/rust-clippy/blob/eee3112dc343fc52d2221bffa4d832c9c27df054/tests/ui/missing_panics_doc.rs. Can we extend on that instead of creating a new test file?

@dswij dswij added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 15, 2023
@KisaragiEffective
Copy link
Contributor Author

KisaragiEffective commented Jun 16, 2023

Oh, I didn't notice it; fixed it :)

@KisaragiEffective KisaragiEffective requested a review from dswij June 16, 2023 07:47
@KisaragiEffective
Copy link
Contributor Author

KisaragiEffective commented Jun 16, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 16, 2023
dswij
dswij approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for addressing the comments!

@dswij
Copy link
Member

dswij commented Jun 16, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 16, 2023

📌 Commit 73c0c14 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 16, 2023

⌛ Testing commit 73c0c14 with merge 43ecf8e...

@bors
Copy link
Contributor

bors commented Jun 16, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 43ecf8e to master...

@bors bors merged commit 43ecf8e into rust-lang:master Jun 16, 2023
@bors bors mentioned this pull request Jun 16, 2023
Closed
@KisaragiEffective KisaragiEffective deleted the missing_panics_doc_trigger_on_expect branch June 16, 2023 10:00
@ecton ecton mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[missing_panics_doc] doesn't trigger on expect

4 participants

@KisaragiEffective @rustbot @dswij @bors