-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Also inspect doc block comments #10783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
This is bypassing the markdown parsing which I'm not super keen on, without fixing the root of the problem we'd still have similar issues for any other doc based lint, e.g. for |
Sorry for the wait. I was in Portugal without access to a computer. |
☔ The latest upstream changes (presumably #10953) made this pull request unmergeable. Please resolve the merge conflicts. |
f5b164c
to
4ca46f4
Compare
☔ The latest upstream changes (presumably #10976) made this pull request unmergeable. Please resolve the merge conflicts. |
4ca46f4
to
b38e07a
Compare
b38e07a
to
cbaecb6
Compare
Is there something more to change in this PR? |
I had the thought that it wouldn't account for spans on the other lints e.g. |
I forgot to actually add the I'll add it soon |
Just tested it. It does indeed bug the spans on |
47bb327
to
56ce54b
Compare
Fixed =) |
It doesn't seem to work with #![warn(clippy::doc_markdown)]
pub mod a {
/**
StructName
*/
pub fn f() {}
} |
Almost 100 days now, I'll change the approach as this isn't working. |
I'll have to close this, sadly I don't have the time to research this issue further, I'll leave it free for someone else that has the time to fix it. |
The system that checked for certain things in Documentation, wouldn't work with code blocks (with only one
*
). This PR fixes that.More info in the linked issue.
Fixes #10277
changelog: Fix lints that were silenced because of the use of
/** ...*/
instead of///