Skip to content

Conversation

@beetrees
Copy link
Contributor

@beetrees beetrees commented Apr 3, 2023

Use sess.warn to display the multiple clippy.toml warning instead of eprintln!.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 3, 2023
@flip1995
Copy link
Member

flip1995 commented Apr 3, 2023

Uh, nice!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 3, 2023

📌 Commit afdfbf8 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 3, 2023

⌛ Testing commit afdfbf8 with merge 9e53b65...

@bors
Copy link
Contributor

bors commented Apr 3, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 9e53b65 to master...

@bors bors merged commit 9e53b65 into rust-lang:master Apr 3, 2023
@beetrees beetrees deleted the warnings-not-eprintln branch April 3, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants