Skip to content

lintcheck: fix clap panic #10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Feb 12, 2023

clap 4.1.4 panics if - is used at the start of an argument:

$ cargo lintcheck
[…]
thread 'main' panicked at 'Argument recursive: long "--recursive" must not start with a `-`, that will be handled by the parser', /home/sam/.cargo/registry/src/git.colasdn.top-1ecc6299db9ec823/clap-4.1.4/src/builder/debug_asserts.rs:82:13

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2023
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Feb 12, 2023

📌 Commit aeaa1cc has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 12, 2023

⌛ Testing commit aeaa1cc with merge ad2135e...

@bors
Copy link
Contributor

bors commented Feb 12, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ad2135e to master...

@bors bors merged commit ad2135e into rust-lang:master Feb 12, 2023
@samueltardieu samueltardieu deleted the lintcheck-clap-panic branch February 12, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants