[drop_ref]: don't lint idiomatic in match arm
#10142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
@kraktus Could you please take a look at this PR, since you worked on this code previously? |
ericwu17
force-pushed
the
drop_ref-FP
branch
2 times, most recently
from
61a4389 to
bd8977a
Compare
|
Sounds good to me 👍 |
|
Thank you, that looks like a sensible approach. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10122
As established in issue #9482, it is idiomatic to use a single
drop()expression in a match arm to achieve a side-effect of a function while discarding its output. This should also apply to cases where the function returns a reference.The change to the lint's code was less than 1 line, because all the heavy lifting was done in PR #9491.
changelog: FP: [
drop_ref]: No longer lints idiomatic expression inmatcharms#10142