#590 - Renamed chooser to visitor and added function for parsed macro… #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test it in the |
fitzgen
reviewed
Mar 17, 2017
src/lib.rs
Outdated
| @@ -447,8 +447,8 @@ impl Builder { | |||
|
|
|||
| /// Allows configuring types in different situations, see the `TypeChooser` | |||
| /// documentation. | |||
| pub fn type_chooser(mut self, cb: Box<chooser::TypeChooser>) -> Self { | |||
| self.options.type_chooser = Some(cb); | |||
| pub fn type_chooser(mut self, cb: Box<visitor::BindgenVisitor>) -> Self { | |||
|
Apologies for bike shedding, but I'm not in love with the name Spitting out anything that comes to mind:
Any other ideas? |
|
I'm liking onParse or ParseCallbacks, myself. |
|
ParseCallbacks SGTM |
emilio
reviewed
Mar 17, 2017
bindgen-integration/build.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| struct MacroVisitor { | ||
| macros: Arc<RwLock<HashSet<String>>>, |
|
|
||
| fn main() { | ||
| gcc::Config::new() | ||
| .cpp(true) | ||
| .file("cpp/Test.cc") | ||
| .compile("libtest.a"); | ||
|
|
||
| let macros = Arc::new(RwLock::new(HashSet::new())); | ||
|
|
|
This looks fine to me renamed to |
Added tests and fixed missed function rename. Fixed nits Renamed visitor to callbacks. Renamed visitor to callbacks. Renamed visitor to callbacks. Fixed text.
|
Squashed! |
emilio
changed the title
|
@bors-servo r+ Thanks! |
|
📌 Commit 7908561 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 18, 2017
How would you suggest testing this?
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How would you suggest testing this?