Skip to content

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 6, 2017

Done while investigating #380.

r? @fitzgen

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean up :)

@fitzgen
Copy link
Member

fitzgen commented Jan 11, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 12fd256 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 12fd256 with merge df043bf...

bors-servo pushed a commit that referenced this pull request Jan 11, 2017
Tidy up and test virtual inheritance handling.

Done while investigating #380.

r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 12fd256 into rust-lang:master Jan 11, 2017
jethrogb pushed a commit to jethrogb/rust-bindgen that referenced this pull request Oct 18, 2019
Adding an example of wrapping the generated bindings in a module to avoid the issue with `include!` and top-level inner attributes that a few people seem to be running into.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants