Skip to content

Update quasi to 0.21 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Nov 17, 2016

This is not the latest version, because the latest version doesn't work
due to serde-deprecated/quasi#65.

The issue of keeping using 0.20 is that libbindgen depends on aster 0.28
while quasi depends on aster 0.27, which leads to duplicate versions of
aster dependency. Updating quasi to 0.21 brings aster to 0.29, which
also works for libbindgen.

This is not the latest version, because the latest version doesn't work
due to serde-deprecated/quasi#65.

The issue of keeping using 0.20 is that libbindgen depends on aster 0.28
while quasi depends on aster 0.27, which leads to duplicate versions of
aster dependency. Updating quasi to 0.21 brings aster to 0.29, which
also works for libbindgen.
@upsuper
Copy link
Contributor Author

upsuper commented Nov 17, 2016

And serde-deprecated/quasi#65 exists since 0.22, so 0.21 is actually the only version we can use without duplicate aster at the moment.

@emilio
Copy link
Contributor

emilio commented Nov 17, 2016

Looks good, thanks!

@bors-servo r+

@bors-servo
Copy link

📌 Commit c007e84 has been approved by emilio

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit c007e84 into rust-lang:master Nov 17, 2016
bors-servo pushed a commit that referenced this pull request Nov 17, 2016
Update quasi to 0.21

This is not the latest version, because the latest version doesn't work
due to serde-deprecated/quasi#65.

The issue of keeping using 0.20 is that libbindgen depends on aster 0.28
while quasi depends on aster 0.27, which leads to duplicate versions of
aster dependency. Updating quasi to 0.21 brings aster to 0.29, which
also works for libbindgen.
@upsuper upsuper deleted the update-quasi branch November 17, 2016 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants