Add an option to avoid converting to f32/f64 automatically float types. #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
force-pushed
the
dont-override-float
branch
2 times, most recently
from
2073bbb to
6a621b8
Compare
fitzgen
approved these changes
Nov 7, 2016
| @@ -63,6 +63,8 @@ Options: | |||
| --use-msvc-mangling Handle MSVC C++ ABI mangling; requires that | |||
| target be set to (i686|x86_64)-pc-win32 | |||
|
|
|||
| --no-convert-floats Don't convert floats automatically to f32/f64 | |||
There was a problem hiding this comment.
NItpick: add a period to complete the sentence.
emilio
force-pushed
the
dont-override-float
branch
from
6a621b8 to
1091a42
Compare
|
@bors-servo r=fitzgen |
|
📌 Commit 1091a42 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 8, 2016
Add an option to avoid converting to f32/f64 automatically float types. This implements another feature that we need for parity with upstream bindgen. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements another feature that we need for parity with upstream bindgen.
r? @fitzgen