clang: Some partially specialized templates return no template argument count. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Nov 2, 2016
| @@ -193,7 +193,7 @@ impl Cursor { | |||
| /// Is the referent a fully specialized template specialization without any | |||
| /// remaining free template arguments? | |||
| pub fn is_fully_specialized_template(&self) -> bool { | |||
| self.is_template() && self.num_template_args().unwrap() > 0 | |||
| self.is_template() && self.num_template_args().unwrap_or(0) > 0 | |||
There was a problem hiding this comment.
Leave a TODO comment with a reference to the issue that @bholley filed?
|
Added a test and a comment pointing to that issue and this PR. @bors-servo r=fitzgen |
|
📌 Commit ef59d9e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 2, 2016
clang: Some partially specialized templates return no template argument count. Trying to construct a test case, meanwhile: r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to construct a test case, meanwhile: r? @fitzgen